Remove FramesV1 #382
Merged
Remove FramesV1 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
approved these changes
Feb 11, 2025
nplasterer
added a commit
that referenced
this pull request
Feb 12, 2025
* remove pinned frame url from android * update libxmtp ref for pinned frame removal and db lock fix * add message expiration to group and dm * add ability to update expiration state * add permission policy update * write a test for disappearing messages * remame * more renames * small tweaks to impl * try to get the tests to pass * try to mirror disappearing message * try updating test * update bindings * update the test * small test tweak * getting closer on the test * add tests for dms as well * get it passing for dms * fix up the lint * rename * more clean up * fix lint * fix lint * remove small code from test * remove frames V1 (#382) * Make addWallet a delicate API (#381) * add a delicate api warning level * slightly update the logic * Update library/src/main/java/org/xmtp/android/library/Client.kt Co-authored-by: Nicholas Molnar <[email protected]> * add a test for this case * fix lint --------- Co-authored-by: Nicholas Molnar <[email protected]> * tweak slightly the name --------- Co-authored-by: Cameron Voell <[email protected]> Co-authored-by: cameronvoell <[email protected]> Co-authored-by: Nicholas Molnar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove framesV1 from the first class SDK support.