Chore/update metadata remover #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jduncan-xoi
commented
Mar 4, 2024
jduncan-xoi
commented
- switch to Typescript
- switch to Vite and Vitest
- use a logger vs console.logs
|
First of all how dare you |
The legend is alive! |
|
@Aleclindner might as well review this since you're already here |
calebgregory
reviewed
Mar 5, 2024
Comment on lines
-26
to
-39
| "@babel/cli": "7.18.10", | ||
| "@babel/core": "^7.11.0", | ||
| "@babel/plugin-transform-modules-commonjs": "^7.11.0", | ||
| "@babel/preset-env": "^7.11.0", | ||
| "@babel/preset-flow": "^7.11.0", | ||
| "babel-plugin-transform-remove-console": "^6.9.4", | ||
| "flow-bin": "^0.109.0", | ||
| "flow-copy-source": "^2.0.9", | ||
| "ffprobe": "^1.1.0", | ||
| "ffprobe-static": "^3.0.0", | ||
| "ffprobe-static": "^3.1.0", | ||
| "gm": "^1.23.1", | ||
| "hasha": "^5.2.0", | ||
| "is-corrupted-jpeg": "^1.0.2", | ||
| "jest": "^26.6.3", |
There was a problem hiding this comment.
this diff hits like a warm shower after a long day of working outside in the sun.
Aleclindner
reviewed
Mar 5, 2024
| const entryNumberDataView = await readNextChunkIntoDataView(2, startOffset, read) | ||
| const entries = entryNumberDataView.getUint16(0, littleEndian) | ||
| const entryOffset = startOffset + 2 | ||
| // kill 'em all | ||
| console.log('writing 0s on gps data...', entries, entryOffset) | ||
| Logger.debug('writing 0s on gps data...', entries, entryOffset) |
There was a problem hiding this comment.
might be a good idea to just take the logs out at this point, I was mostly just using them to figure out how this stuff worked when I was writing it
Aleclindner
approved these changes
Mar 5, 2024
|
Approved and left one optional comment |
|
also rename this to privilege/update metadata remover |
danielxoi
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.