Return {}
as empty object instead of empty array
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and be consistent with emitting empty objects as
{}
.Before
Emitting an empty object as JSON after reading it results in it being output as an empty array:
After
Consistent result:
$ xp -w 'use text\json\Json; Json::of(Json::read("{}"))' {}
Potential pitfalls
Objects (even ones without a single property) are never considered empty:
Also, using sizeof() will raise the following exception: lang.Error (sizeof(): Argument 1 ($value) must be of type Countable|array, stdClass given) - similar to all cases where we use type hints; which would then need to be widened to the (ugly-looking)
array|stdClass
to support this.See also