Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoC] Integrating features/APIs from Call Of Chornobyl merge into OpenXRay #108

Merged
merged 17 commits into from
Dec 20, 2024

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented Dec 19, 2024

Changes

  • Package dependencies updated
  • Use CoC save/load callbacks, remove custom implementation, add global events
  • Add level_input.on_key_press callback
  • Adding weapon magazine empty / weapon jammed / hud animation ended callbacks
  • CUIActorMenu_OnItemFocusLost / CUIActorMenu_OnItemFocusReceive / CInventory_ItemAvailableToTrade callbacks added
  • ai_stalker.update_best_weapon callback added
  • CSE_ALifeDynamicObject_on_unregister callback added
  • CALifeUpdateManager__on_before_change_level callback added
  • visual_memory_manager.get_visible_value callback added
  • Tests/mocks update

New logics for stalkers visibility calculation.

Checklist

  • tests are included
  • documentation is changed or added

Links / references

OpenXRay/xray-16#1751
OpenXRay/xray-16#1754
OpenXRay/xray-16#1756
OpenXRay/xray-16#1395
xray-forge/xray-16-types#1
https://github.com/revolucas/CoC-Xray/tree/master

@Neloreck Neloreck self-assigned this Dec 19, 2024
@github-actions github-actions bot added test Changes are updating or introducing unit tests managers Changes are affecting game managers scripts labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 98.82353% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (b90a2fe) to head (2e16245).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/engine/core/binders/creature/ActorBinder.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   72.76%   72.81%   +0.04%     
==========================================
  Files        1301     1304       +3     
  Lines       36685    36752      +67     
  Branches     6244     6254      +10     
==========================================
+ Hits        26695    26762      +67     
  Misses       9990     9990              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ai Changes are affecting stalkers AI/state logic label Dec 20, 2024
@Neloreck Neloreck changed the title [CoC] Integrating features from Call Of Chornobyl merge into OpenXRay [CoC] Integrating features/APIs from Call Of Chornobyl merge into OpenXRay Dec 20, 2024
Signed-off-by: Neloreck <[email protected]>
…ect_on_unregister` implemented, `visual_memory_manager.get_visible_value` implemented. `IS_UNDERGROUND_WEATHER` config value added.

Signed-off-by: Neloreck <[email protected]>
…_before_change_level` handler and event.

Signed-off-by: Neloreck <[email protected]>
@Neloreck Neloreck marked this pull request as ready for review December 20, 2024 19:34
@github-actions github-actions bot added the cli Changes are affecting XRF cli tools label Dec 20, 2024
@Neloreck Neloreck merged commit d892bf5 into main Dec 20, 2024
13 checks passed
@Neloreck Neloreck deleted the coc-oxr-integration branch December 20, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Changes are affecting stalkers AI/state logic cli Changes are affecting XRF cli tools dependencies managers Changes are affecting game managers scripts test Changes are updating or introducing unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant