Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEAPONS] Update default weapons models/textures/sounds. #112

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented Jan 4, 2025

Changes

  • Remove MP configs
  • Add weapon LTX configs
  • Update XRF tools and related commands
  • Move particles/textures unpacked variants to separate folders
  • Corrected weapon constants
  • Allow 0/null delay with timeout callbacks

Checklist

  • tests are included
  • documentation is changed or added

Links / references

@github-actions github-actions bot added the configs Changes are affecting ltx configuration label Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 48.09160% with 68 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (e6920f6) to head (321296c).

Files with missing lines Patch % Lines
...rc/engine/core/managers/sounds/objects/NpcSound.ts 21.68% 65 Missing ⚠️
...gine/core/managers/events/AbstractTimersManager.ts 0.00% 2 Missing ⚠️
.../core/managers/debug/profiling/ProfilingManager.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   73.05%   73.06%   +0.01%     
==========================================
  Files        1310     1309       -1     
  Lines       37016    37038      +22     
  Branches     6268     6279      +11     
==========================================
+ Hits        27041    27062      +21     
- Misses       9975     9976       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neloreck Neloreck self-assigned this Jan 4, 2025
…m from build assets step. Increase logging file limits.

Signed-off-by: Neloreck <[email protected]>
@github-actions github-actions bot added the cli Changes are affecting XRF cli tools label Jan 5, 2025
@github-actions github-actions bot added the managers Changes are affecting game managers label Jan 7, 2025
Signed-off-by: Neloreck <[email protected]>
Signed-off-by: Neloreck <[email protected]>
@github-actions github-actions bot added the test Changes are updating or introducing unit tests label Jan 7, 2025
@github-actions github-actions bot added ui Changes are affecting game UI / forms scripts dependencies labels Jan 26, 2025
Signed-off-by: Neloreck <[email protected]>
Signed-off-by: Neloreck <[email protected]>
Signed-off-by: Neloreck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Changes are affecting XRF cli tools configs Changes are affecting ltx configuration dependencies managers Changes are affecting game managers scripts test Changes are updating or introducing unit tests ui Changes are affecting game UI / forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant