Merge pull request #1861 from Tyriar/1860_style_npe

Add sanity checks to dom renderer underline code
xtermjs · Jan 1, 2019 · 68b2b79 · 68b2b79
2 parents 4375b3c + 8b3513f
commit 68b2b79
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/renderer/dom/DomRenderer.ts b/src/renderer/dom/DomRenderer.ts
@@ -364,9 +364,11 @@ export class DomRenderer extends EventEmitter implements IRenderer {
         return;
       }
       const span = <HTMLElement>row.children[x];
-      span.style.textDecoration = enabled ? 'underline' : 'none';
-      x = (x + 1) % cols;
-      if (x === 0) {
+      if (span) {
+        span.style.textDecoration = enabled ? 'underline' : 'none';
+      }
+      if (++x >= cols) {
+        x = 0;
         y++;
       }
     }