-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get multi-line links working #1303
Conversation
This is ready for review, multi line links seem to work great with the exception of echoing the link and then sizing the terminal down. This happens because of the workaround for reflow where we retain the text to the right of the terminal. Since I plan on adding support for reflow in the next couple of months I don't think it's even worth working around this issue. |
@mofux should be fixed now, added tests too 👍 |
I found another bug that is also likely caused by wrapped lines. If you run |
@mofux I decided to ignore this edge case for now, but you found a case where it looks particularly bad 😛. It happens because we don't bother to backtrack and linkify lines that are outside of the viewport (only initial line (!isWrapped) are linkified). I removed the TODO and make a comment to that effect in b44a11c I guess if the requested line is the first line and it's flagged as wrapped, we could backtrack and linkify. Then add handling to make sure mouse zones are not created outside the viewport. I'll give it a shot. |
@mofux ok I think that fixes it |
@mofux yeah it's an issue with the link detection in general. Since we use regex we either have to decide whether to allow brackets (and quotes) and accept cases like this, or break heaps of links such as https://msdn.microsoft.com/en-us/library/windows/desktop/ms684839(v=vs.85).aspx Tracked in #583 |
I think we can merge this PR. Let's tackle the link detection issues separately. |
Fixes #24