-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linkifier after shrinking #1769
Closed
+134
−102
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c4db617
fix linkifier after shrinking
jerch 93d51c6
Merge branch 'master' into fix_linkifier_after_shrinking
jerch cdc175d
fix test case docs
jerch e855af9
cleanup Linkifier.test.ts
jerch 581d231
fix underline of last cell
jerch d5badcc
change cell content for enlarging resize
jerch 1218c83
workaround for after enlarging
jerch 136f2bd
revert empty cell changes, getTrimmedLength for Bufferline
jerch 0be9873
remove remnant
jerch d1fcfd5
test cases, docs
jerch 1c23b17
Merge branch 'master' into fix_linkifier_after_shrinking
Tyriar 36375c6
workaround without empty cells
jerch b0e2e47
Merge branch 'fix_linkifier_after_shrinking' of git+ssh://github.com/…
jerch 9bab881
Merge branch 'fix_linkifier_after_shrinking' of git+ssh://github.com/…
jerch 8301068
Merge branch 'fix_linkifier_after_shrinking' of git+ssh://github.com/…
jerch 1b17ce2
Merge branch 'master' into fix_linkifier_after_shrinking
jerch fff3337
fix tests
jerch ae905ec
remove readded stuff
jerch fb92452
reset cell behind early wrap
jerch c7fa89d
apply new trimming to linkifier
jerch b549add
Merge branch 'master' into fix_linkifier_after_shrinking
jerch 635fc72
handle invalid string buffer indices
jerch f91dde8
add sanity check for visible length
jerch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
workaround without empty cells
commit 36375c62a963f141dd948e01e4f6184de66bc671
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using visibleLength mean URLs will be broken if the viewport is shrunk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visibleLength is just there to give the marker the length to underline. This makes sure that the underline does not over- or underflow the real end of the URL. So after shrinking the underline should stick to chars that really belong to the URL. Side effect of this - after enlarging inserted empty cells are also underlined. To get rid of this, the underline marker would have to support multiple chunks to underline.