DOM renderer: Don't output empty cells at end of a line #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609
This is an optimization to help make the DOM renderer more viable if the canvas renderer is replaced by #1790
Using the testing process outlined in https://github.com/xtermjs/xterm.js/wiki/Performance-testing#renderer (numbers measured on dc077a1)
87x26 viewport
Before: frames 16, average 11.53ms
After: frames 24, average 5.88ms
300x80 viewport
Before: frames 11, average 115.83ms
After: frames 13, average 17.12ms