-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent changes from master #2282
Conversation
Normally we only do patch releases for very bad bugs, I'm not sure the isWrapped change makes the cut? We expect v4 to go out in about 3-4 weeks but you can use the beta build published to npm if you want to keep up to date. |
Thanks, I afraid that Windows 10 UWP WebView control based on Microsoft Edge rendering engine might will not work good with v4. |
@felixse felixse/FluentTerminal#420 isn't a regression from 3.13 is it?
@Maxris oh? This is news to me? 🤔 |
@Tyriar we had discussion with @felixse previously regarding FluentTerminal incompatibility with upcoming changes in v4: UWP app uses WebView control to render Xterm.js; WebView control embeds "Microsoft Edge" engine; And Edge still doesn't support webgl2 https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6517037-webgl-2-0 ; it seems you did the switch to webgl2 based rendering #1790 . I'm curious if it's possible to develop some plan of support for UWP platform in upcoming v4 release? |
@Maxris the WebGL renderer is completely opt-in right now, v5 is probably when we'll remove the canvas renderer, but there will always be the DOM one that will work in all browsers. v5 is probably another year or so off given our history. FluentTerminal should work just fine as it always has, just don't use the WebGL renderer on Windows. I'm going to close this as I don't think these changes meet the bar for a patch release. |
@Tyriar makes sense, thank you! |
@Maxris I'll do it tomorrow if I get the time, should be just cherry picking the commits. |
No description provided.