Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add onContextLoss to webgl addon #3276

Merged
merged 6 commits into from
Apr 2, 2021
Merged

add onContextLoss to webgl addon #3276

merged 6 commits into from
Apr 2, 2021

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Apr 1, 2021 •
edited by Tyriar
Loading

So that VS code can fall back to dom when the webgl renderer loses context

Fixes #2253

@meganrogge meganrogge requested a review from Tyriar April 1, 2021 19:20
@meganrogge meganrogge self-assigned this Apr 1, 2021
Tyriar
Tyriar reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this _onContextLoss instead and pass the actual event over so it can be prevented if desired?

@Tyriar Tyriar added this to the 4.12.0 milestone Apr 1, 2021
@meganrogge meganrogge changed the title add onRecoverContext event add onContextLoss to webgl addon Apr 1, 2021
Tyriar
Tyriar approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after adding the API to https://github.com/xtermjs/xterm.js/blob/master/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts

@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2021

Also I added a bit to the readme on handling context loss, improvements welcome 🙂

@Tyriar Tyriar mentioned this pull request Apr 1, 2021
Closed
@meganrogge meganrogge enabled auto-merge April 1, 2021 23:57
@meganrogge meganrogge merged commit f9945b3 into xtermjs:master Apr 2, 2021
This was referenced Apr 2, 2021
Closed
Closed
This was referenced Oct 11, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Webgl: Handle context loss when there are too many contexts
2 participants
@meganrogge @Tyriar