XWIKI-21782: Incentivize use of header rows for the WYSIWYG editor tables #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles * Added a translation key-value for the warning message * Updated the default value of the table header to `top row` * Added a warning message (style from bootstrap, consistent with the color theme) that is displayed when the user chooses to have No headers for the table.
…bles * Updated test to take into account the new defaults
…bles * Fixed superfluous codestyle change * Improved the translation default value.
mflorea
requested changes
Dec 6, 2024
...wiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-table/plugin.js
Outdated
Show resolved
Hide resolved
...wiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-table/plugin.js
Outdated
Show resolved
Hide resolved
...wiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-table/plugin.js
Outdated
Show resolved
Hide resolved
...wiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-table/plugin.js
Outdated
Show resolved
Hide resolved
...ki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/Translations.xml
Outdated
Show resolved
Hide resolved
...xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/EditSheet.xml
Show resolved
Hide resolved
…bles * Comment improvements Co-authored-by: Marius Dumitru Florea <[email protected]>
…bles * Escaped the translation for HTML * Added comments on the style
|
This PR is ready for further review, and probably a merge. |
mflorea
requested changes
Dec 10, 2024
| // Create a warning message for the accessibility without headers. | ||
| const warningMessage = document.createElement('span'); | ||
| warningMessage.classList.add('box', 'warningmessage'); | ||
| warningMessage.textContent = CKEDITOR.tools.htmlEncode( |
There was a problem hiding this comment.
There's no need to escape HTML when you set the textContent. If you want to use CKEDITOR.tools.htmlEncode() then you can keep your previous code and just call CKEDITOR.tools.htmlEncode() on the translation value. So either use directly the DOM API (textContent) as I suggested, or use string concatenation but with HTML escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21782
Changes
Description
top rowClarifications
Screenshots & Video
We can see on the demo video below that the new default for the table header field is
First row, and selecting theNoneoption displays a warning.https://github.com/user-attachments/assets/fabcea6f-7c02-4bc8-9b64-266e43fefeab
Executed Tests
Looking for
tablein the ckeditor test module only prompted me with one significant result, which isQuickActionsIT#table.The default state of the table changed, so I also changed the output obtained with this minimal set of inputs. After the change of the test,
successfully passed while it did fail without the changes.
Expected merging strategy