XWIKI-22121: Improve the registration experience #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Waited on the password confirmation field to submit the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR aims at fixing the flicker found at https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/master/731/testReport/junit/org.xwiki.administration.test.ui/AllIT$NestedRegisterIT/MySQL_9_1__Tomcat_9_jdk21__Chrome___Docker_tests_for_xwiki_platform_administration___Build_for_MySQL_9_1__Tomcat_9_jdk21__Chrome___Docker_tests_for_xwiki_platform_administration___registerExistingUser_boolean__boolean__boolean__TestUtils__3_/
It seems this does not happen all the time on CI: https://ge.xwiki.org/scans/tests?search.timeZoneId=Europe%2FParis&tests.container=org.xwiki.administration.test.ui.AllIT$NestedRegisterIT
I could not reproduce this issue locally unfortunately, the solution I propose here should work (in regards to a similar fix made yesterday) but I have no way of being certain...
Jira URL
https://jira.xwiki.org/browse/XWIKI-22121
Changes
Description
Clarifications
The failing test fills up the form then tries to submit it. From a very similar regression solved yesterday, it seems like we should wait a bit for the livevalidation javascript to update before trying to submit the form. Adding a wait solved the issue yesterday.
See comments in code for more info.
Screenshots & Video
No visual changes, test changes only.
Executed Tests
After building with
mvn clean install -f xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui, successfully passed the testsmvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -Dit.test=RegisterIT#registerExistingUser. It doesn't say everything though because I could not reproduce the flicker locally. At least I did not break the test completely with the changes.Expected merging strategy