XWIKI-22665: Required rights should be cached

[michitux]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22665

Changes

Description

• Introduce a new SimpleDocumentCache for caching values associated with document references.
• Use the cache in the DocumentRequiredRightsManager.
• Return static instances in DocumentRequiredRightsReader to reduce the memory usage of the cache.
• Remove DocumentRequiredRightsManager from the page test component list and instead add a mock in MockitoOldcore.
• Move DocumentRequiredRightsManager to the authorization bridge as it fits better there and with the mock implementation in MockitoOldcore there is no need to have it available for tests.

Clarifications

• I decided not to use the existing DocumentCache as the internal logic for having several values per key vastly exceeds the memory requirements of the required rights cache.

Screenshots & Video

No UI changes.

Executed Tests

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,quality -pl $(git diff --name-only  --merge-base origin/master | awk -F'/' '{for(i=NF-1; i>0; i--){if($i ~ /src$/){printf(":%s\n", $(i-1)); break;}}}' | sort -u | paste -sd "," -),:xwiki-platform-legacy-oldcore

Manual test of the changed modules in a 17.0.0-SNAPSHOT demo instance.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • stable-16.10.x