notifiy user that voice controlled playback cannot succeed, if podcas…

…t list is empty
y20k · Dec 6, 2019 · 1f8c15f · 1f8c15f
1 parent 366b3e6
commit 1f8c15f
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 4 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -11,8 +11,8 @@ android {
         applicationId 'org.y20k.escapepod'
         minSdkVersion 25
         targetSdkVersion 29
-        versionCode 19
-        versionName '0.8.1'
+        versionCode 20
+        versionName '0.8.2'
         resConfigs "en", "de", "nl", "nb-rNO", "pt"
     }
 

diff --git a/app/src/main/java/org/y20k/escapepod/PlayerService.kt b/app/src/main/java/org/y20k/escapepod/PlayerService.kt
@@ -31,6 +31,7 @@ import android.support.v4.media.MediaMetadataCompat
 import android.support.v4.media.session.MediaControllerCompat
 import android.support.v4.media.session.MediaSessionCompat
 import android.support.v4.media.session.PlaybackStateCompat
+import android.widget.Toast
 import androidx.core.app.NotificationManagerCompat
 import androidx.core.content.ContextCompat
 import androidx.core.os.bundleOf
@@ -563,6 +564,9 @@ class PlayerService(): MediaBrowserServiceCompat(), Player.EventListener, Corout
                 val episodeMediaItem: MediaBrowserCompat.MediaItem? = collectionProvider.getNewestEpisode()
                 if (episodeMediaItem != null) {
                     onPlayFromMediaId(episodeMediaItem.mediaId, null)
+                } else {
+                    Toast.makeText(this@PlayerService, R.string.toast_message_error_no_podcast_found, Toast.LENGTH_LONG).show()
+                    LogHelper.e(TAG, "Unable to start playback. Please add a podcast and download an episode first.")
                 }
             } else {
                 // try to match podcast name and voice query - and start newest episode of that podcast

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -63,6 +63,7 @@
     <string name="toast_message_downloading_episode">Downloading Episode.</string>
     <string name="toast_message_error_feed_not_supported">Unsupported feed (application/Atom+XML).</string>
     <string name="toast_message_error_missing_storage_permission">Grant \"Read Storage\" permission to open this file.</string>
+    <string name="toast_message_error_no_podcast_found">Unable to start playback. Please add a podcast first.</string>
     <string name="toast_message_error_refreshing_cover">Could not refresh cover. The feed does not contain a cover reference.</string>
     <string name="toast_message_error_validation_audio_references">RSS validation: Feed does not contain any audio references.</string>
     <string name="toast_message_error_validation_missing_cover">RSS validation: Feed does not contain a cover reference.</string>

diff --git a/metadata/en-US/changelogs/18.txt b/metadata/en-US/changelogs/18.txt
@@ -1,6 +1,6 @@
 # v0.8.0 - Gehen Die Leute
 
-**2019-12-08**
+**2019-12-05**
 
 - basic podcast search on the gpodder.net service
 - Portuguese language version

diff --git a/metadata/en-US/changelogs/19.txt b/metadata/en-US/changelogs/19.txt
@@ -1,5 +1,5 @@
 # v0.8.1 - Gehen Die Leute
 
-**2019-12-08**
+**2019-12-05**
 
 - prevents a crash caused by playback command issued via voice control, when podcast list is still empty
diff --git a/metadata/en-US/changelogs/20.txt b/metadata/en-US/changelogs/20.txt
@@ -0,0 +1,5 @@
+# v0.8.2 - Gehen Die Leute
+
+**2019-12-06**
+
+- notifies user that voice controlled playback cannot succeed, if podcast list is empty.