Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire Rewrite #108

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Entire Rewrite #108

wants to merge 21 commits into from

Conversation

clxxiii
Copy link
Collaborator

@clxxiii clxxiii commented Jul 28, 2023

⚠THIS IS A FULL REWRITE OF THE PROGRAM ⚠

This pull request fully replaces the entire architecture of the project, in a desperate attempt to improve code quality and stability.

Features:

Is it stable now? no.
Is it ready to be pushed? no.
Is all of the code that actually applies to the vision of the product jumbled together with useless lines in a 3000 line file? no.

So I'd say it's worth it.

This also removes a large portion of the discord bot in favor of the web interface

Things that need to be changed before pushed:

  • A bug where the ready phase sends the glhf message 4 times (literally no clue how this happened)
  • A feature-complete web frontend (unrelated to this repo (yet))
  • 1/100 chance the bot says golf instead of glhf
  • Needs to be tested in a real match (at least one 2v2 match, and one 1v1 match)
  • Users spamming commands/ready should not duplicate responses (it currently does)
  • Bug with rolling where it ignores some messages (may be fixed with the spamming one)
  • Tests for bracket match handlers written (the whole point of this architecture rework is so I can write tests)
  • Timers need to be enforced (currently does not exist)
  • Removal of /create-match command from discord bot (currently does exist)

@clxxiii clxxiii added this to the Entire Rewrite Merge milestone Oct 5, 2023
@clxxiii clxxiii removed this from the Entire Rewrite Merge milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Picking Strategy to use "Pick Slots" rather than a hard-coded order
2 participants