Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): added Action support #4

Merged
merged 6 commits into from
Mar 18, 2024
Merged

feat(action): added Action support #4

merged 6 commits into from
Mar 18, 2024

Conversation

cnlangzi
Copy link
Member

Changes

  • added Action support

Copy link
Contributor

deepsource-io bot commented Mar 18, 2024

Here's the code health analysis summary for commits c749421..0c29834. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c749421) to head (0c29834).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           65       113   +48     
=========================================
+ Hits            65       113   +48     
Flag Coverage Δ
Unit-Tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

General suggestions:

  • Ensure the new 'Action' abstraction is clearly documented to guide users on how to leverage it effectively.
  • Review the error handling strategy for the new 'Action' support to ensure it aligns with the package's overall design principles.
  • Consider the impact of the introduced changes on existing users of the package and provide migration guidelines if necessary.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

awaiter_test.go Show resolved Hide resolved
waiter.go Show resolved Hide resolved
waiter.go Outdated Show resolved Hide resolved
waiter_test.go Show resolved Hide resolved
@cnlangzi cnlangzi merged commit 74db4a9 into main Mar 18, 2024
6 checks passed
@cnlangzi cnlangzi deleted the feat/action branch March 18, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants