Skip to content

Commit

Permalink
Drop unused constants to make newer versions of clang happy (envoypro…
Browse files Browse the repository at this point in the history
…xy#37970)

Commit Message:

On newer version of Clang those generate a warning and with the settings
we use ultimately result in a compilation failure.

We probably should either disable the warning or just adjust the test.
Looking at the history of the test, it seems that these constants have
never been used, so I prefer to just drop them.

Additional Description:

It's related to envoyproxy#37911, it appears that the compiler warning that causes
this test fail to compile on clang 18 didn't exist in clang 14 that we
are currently using.

Risk Level: Low
Testing: by running changed test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Mikhail Krinkin <[email protected]>
  • Loading branch information
krinkinmu authored Jan 13, 2025
1 parent df4ca65 commit 77bc35a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/extensions/filters/http/oauth2/filter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ using testing::ReturnRef;

static const std::string TEST_CALLBACK = "/_oauth";
static const std::string TEST_CLIENT_ID = "1";
static const std::string TEST_CLIENT_SECRET_ID = "MyClientSecretKnoxID";
static const std::string TEST_TOKEN_SECRET_ID = "MyTokenSecretKnoxID";
static const std::string TEST_DEFAULT_SCOPE = "user";
static const std::string TEST_ENCODED_AUTH_SCOPES = "user%20openid%20email";
static const std::string TEST_STATE_CSRF_TOKEN =
Expand Down

0 comments on commit 77bc35a

Please sign in to comment.