Skip to content

Move items from devDeps to peerDeps and update peerDepsMeta to clarify dependencies #84

Move items from devDeps to peerDeps and update peerDepsMeta to clarify dependencies

Move items from devDeps to peerDeps and update peerDepsMeta to clarify dependencies #84

Triggered via pull request October 1, 2024 03:03
Status Failure
Total duration 39s
Artifacts

ci.yml

on: pull_request
Floating Dependencies
25s
Floating Dependencies
Matrix: try-scenarios
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Floating Dependencies
Process completed with exit code 1.
Tests
Process completed with exit code 1.
Tests: addon/components/basic-dialog.js#L2
Don't use computed properties with native classes. Use getters or @Tracked properties instead
Tests: addon/components/basic-dialog.js#L4
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)
Tests: addon/components/basic-dialog.js#L26
You cannot use the init() lifecycle hook in non-classic classes, it is a classic lifecycle hook. Convert to using the constructor instead, or add the @classic decorator to the class to mark it as classic
Tests: addon/components/basic-dialog.js#L107
Do not use classic ember components lifecycle hooks. Prefer using "@ember/render-modifiers" or custom functional modifiers
Tests: addon/components/basic-dialog.js#L154
Do not use classic ember components lifecycle hooks. Prefer using "@ember/render-modifiers" or custom functional modifiers
Tests: addon/components/in-place-dialog.js#L2
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)
Tests: addon/components/liquid-dialog.js#L10
You cannot use the init() lifecycle hook in non-classic classes, it is a classic lifecycle hook. Convert to using the constructor instead, or add the @classic decorator to the class to mark it as classic
Tests: addon/components/modal-dialog.js#L2
Don't use computed properties with native classes. Use getters or @Tracked properties instead
Tests: addon/components/modal-dialog.js#L4
Don't use computed properties with native classes. Use getters or @Tracked properties instead
Tests: addon/components/modal-dialog.js#L5
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)