Fix tests

[jreidinger]

Problem

build failing at https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:G/yast2-packager/standard/x86_64

Solution

Fix test to use proper string instead of Pathname.

Testing

• Tested manually

[mvidner]

https://github.com/yast/yast-ruby-bindings/blob/9a50d95be89f3dfe81cd109e6bf89a5fbedc48eb/src/ruby/yast/y2logger.rb#L48 shows that we're using a standard logger, and the Ruby documentation shows that passing a block will avoid evaluating it when debugging is disabled.

So please use log.debug { "nasty string #{mem_bomb}" } instead

BTW that Ruby docs is so skillful in hiding the useful information, it sucks

[jreidinger]

@mvidner sadly block form does not work, as we do not limit access to debug in logger level but on ruby-bindings level

try yourself in irb:

1 require "yast"
  2 
  3 include Yast::Logger
  4 
  5 log.debug { puts "eval"; "log content" }

[mvidner]

Ah, good point. Then what about

1. make an Issue in ruby-bindings "log.debug { expensive } always evaluates the block"
2. leave the calls here, commented out, referencing that issue

[jreidinger]

issue created yast/yast-ruby-bindings#290

[mvidner]

Fixes so far look good, but what about

• the other failure "unexpected message :define_method with ("switch_to_richtext=")", do you need help?
• version + changelog?

[coveralls]

Coverage: 37.369% (-0.01%) from 37.38% when pulling c3929ca on fix_tests into 58c7753 on master.

[mvidner]

Does that mean that any such stub_const("Yast::Foo", double) will fail or has bug? We have more

https://github.com/search?q=org%3Ayast+stub_const&type=code

[mvidner]

yast/yast-update/test/inst_update_partition_auto_test.rb
15: stub_const("Yast::FileSystems", double)
yast/yast-installation/test/snapshots_finish_test.rb
10: stub_const("Yast::StorageSnapper", double)
and more

[mvidner]

Thanks!

I think there is still a chance that another fix will be needed in ruby-bindings because of the following, but I will not let that block this PR.

Does that mean that any such stub_const("Yast::Foo", double) will fail or has bug? We have more: https://github.com/search?q=org%3Ayast+stub_const&type=code

[mvidner]

For the record, the stub_const fix adjusts for the change done in yast/yast-ruby-bindings#289

[yast-bot]

✔️ Public Jenkins job #207 successfully finished
✔️ Created OBS submit request #1077710

[yast-bot]

❌ Internal Jenkins job #123 failed

[yast-bot]

❌ Internal Jenkins job #124 failed