switch from Base.convert to GeoInterface.convert (#359)

yeesian · Jan 7, 2023 · dd34eed · dd34eed · yeesian · Jan 7, 2023
1 parent 17d6a1c
commit dd34eed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - breaking: Updated compat for GDAL.jl 1.5 and fixed tests for GDAL 3.6. These include changes to `gdalnearblack`, `fillunsetwithdefault!` and `gdalgetgeotransform`.
+- breaking: Use `GeoInterface.convert` instead of `convert` to convert geometries from other
+  packages to ArchGDAL via the GeoInterface. Example: `GeoInterface.convert(AG.IGeometry, geom)`
 
 ## [0.9.4] - 2022-12-30
 

diff --git a/src/geointerface.jl b/src/geointerface.jl
@@ -278,20 +278,7 @@ let pointtypes = (wkbPoint, wkbPoint25D, wkbPointM, wkbPointZM),
         return toWKT(geom)
     end
 
-    function Base.convert(::Type{T}, geom::X) where {T<:IGeometry,X}
-        return Base.convert(T, GeoInterface.geomtrait(geom), geom)
-    end
-    function Base.convert(
-        ::Type{T},
-        ::GeometryTraits,
-        geom::T,
-    ) where {T<:IGeometry}
-        return geom
-    end  # fast fallthrough without conversion
-    function Base.convert(::Type{T}, ::Nothing, geom::T) where {T<:IGeometry}
-        return geom
-    end  # fast fallthrough without conversion
-    function Base.convert(
+    function GeoInterface.convert(
         ::Type{T},
         type::GeometryTraits,
         geom,

diff --git a/test/test_geometry.jl b/test/test_geometry.jl
@@ -1005,7 +1005,7 @@ import GeoFormatTypes as GFT
         GI.getgeom(::GI.LineStringTrait, geom::MyLine, i) = MyPoint()
 
         geom = MyLine()
-        ag_geom = convert(AG.IGeometry, geom)
+        ag_geom = GI.convert(AG.IGeometry, geom)
         GI.coordinates(ag_geom) == [[1, 2], [1, 2]]
     end
 end