Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReleaseBinaries.java:47-49: Implement attaching artifacts... #1371

Open
0pdd opened this issue Jul 11, 2022 · 3 comments
Open

ReleaseBinaries.java:47-49: Implement attaching artifacts... #1371

0pdd opened this issue Jul 11, 2022 · 3 comments
Labels
bug pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2022

The puzzle 662-8cc0c29a from #662 has to be resolved:

rultor/src/main/java/com/rultor/agents/github/ReleaseBinaries.java

Lines 47 to 49 in c4e1c8e

* @todo #662:30min Implement attaching artifacts to release, remove PMD
* suppression below and enable attachesBinariesToRelease test. Similar
* functionality exists in CommentsTag so you can look there for clues.

The puzzle was created by @yegor256 on 11-Jul-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Jul 11, 2022
@dependabot
Bump junit from 4.12 to 4.13.1
c4e1c8e 
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](junit-team/junit4@r4.12...r4.13.1)

---
updated-dependencies:
- dependency-name: junit:junit
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@0pdd 0pdd mentioned this issue Jul 11, 2022
Closed
@yegor256
Copy link
Owner

@yasamprom try this one

@yasamprom
Copy link

@yegor256 Have I understood correctly that I need to implement putting binaries to assets?

@yegor256
Copy link
Owner

@yasamprom yes, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pdd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @0pdd @yasamprom