Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach binaries to Github releases #662

Closed
yegor256 opened this issue Nov 23, 2014 · 25 comments
Closed

attach binaries to Github releases #662

yegor256 opened this issue Nov 23, 2014 · 25 comments

Comments

@yegor256
Copy link
Owner

yegor256 commented Nov 23, 2014

Let's make it possible to attach binaries to Github releases. For example, in .rultor.yml:

release:
  artifacts:
    - "target/rultor-${tag}.jar"

Rultor should get that target/rultor-${tag}.jar file and attach it as a binary artifact to the Github release created.


@alex-palevsky
Copy link
Contributor

we'll find someone to do this task, soon

@alex-palevsky
Copy link
Contributor

thanks for this report, I added 15 mins to your account, in transaction 000-416ae4ff

@alex-palevsky
Copy link
Contributor

@caarlos0 it is in your hands now, proceed when you can

@alex-palevsky
Copy link
Contributor

@caarlos0 you were holding this task for too long, it is not yours any more, stop now

@alex-palevsky
Copy link
Contributor

@wentwog can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here

The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@alex-palevsky
Copy link
Contributor

@wentwog the task is your hands for the last 8 days.. keep in mind that if it's not closed in the next 40 hours, it will be re-assigned to someone else, see No Obligations principle. -5 added to your rating, current score is: +20

@wentwog
Copy link
Contributor

wentwog commented Jan 3, 2015

@alex-palevsky I understand. Sorry. Better give this task to someone else since I feel I won't be able to meet the deadline.

@alex-palevsky
Copy link
Contributor

@alex-palevsky I understand. Sorry. Better give this task to someone else since I feel I won't be able to meet the deadline.

@wentwog right, I will find someone else, no problem

@alex-palevsky
Copy link
Contributor

@dpisarenko the task is yuors now go ahead

@alex-palevsky
Copy link
Contributor

@dpisarenko this ticket is not yours any more, thanks

@alex-palevsky
Copy link
Contributor

@alevohin it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket. The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@alevohin
Copy link
Contributor

alevohin commented Jan 8, 2015

@alex-palevsky could you assing this ticket for someone else? I have OS Windows on my workstation, unit test fails under Windows.

@alex-palevsky
Copy link
Contributor

@alex-palevsky could you assing this ticket for someone else? I have OS Windows on my workstation, unit test fails under Windows.

@alevohin OK, I will try to assign someone else

@alex-palevsky
Copy link
Contributor

@wb14123 This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here... The budget of this task is 30 mins. This is exactly how much time will be compensated, when the task is completed. Read about our Definition of Done

@alex-palevsky
Copy link
Contributor

@wb14123 you're working with this ticket for the last 16 days. If it's not closed within the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck; -30 to your rating, your total score is -15

@alex-palevsky
Copy link
Contributor

@wb14123 it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle. added -60 to your rating, now it is equal to -345

@alex-palevsky
Copy link
Contributor

@krzyk this is your task now, help us

krzyk pushed a commit to krzyk/rultor that referenced this issue Feb 7, 2015
@krzyk
Copy link

krzyk commented Feb 7, 2015

PR #769

krzyk pushed a commit to krzyk/rultor that referenced this issue Feb 8, 2015
@alex-palevsky
Copy link
Contributor

there is a puzzle in this code 662-8cc0c29a, we'll resolve it later

@krzyk
Copy link

krzyk commented Feb 21, 2015

@yegor256 please close this issue, it has been merged to master

@yegor256
Copy link
Owner Author

@krzyk thanks!

@alex-palevsky
Copy link
Contributor

@krzyk Thanks so much! Your account was topped up for 30 mins (transaction ID is 52107396). +30 to your rating, your total score is +4538

@jeromebridge
Copy link

This doesn't seem to be working for me. Here is the configuration I'm using:

install: |-
  sudo apt-get -q -y install lib32z1 lib32ncurses5 lib32bz2-1.0
release:
  pre: false
  artifacts:
    - "inspro-fitnesse-installer/dist/inspro-fitnesse-installer-${tag}.exe"
  script: |
    mvn versions:set "-DnewVersion=${tag}" -DartifactId=* -DgroupId=* -DoldVersion=*
    git commit -am "${tag}"
    mvn clean deploy --settings documentation/files/maven-settings.xml -Prelease

Here is what Rultor says it knows:

<?xml version="1.0" encoding="UTF-8"?>
<p>
   <entry key="install">sudo apt-get -q -y install lib32z1 lib32ncurses5 lib32bz2-1.0</entry>
   <entry key="release">
      <entry key="pre">false</entry>
      <entry key="artifacts">
         <item>inspro-fitnesse-installer/dist/inspro-fitnesse-installer-${tag}.exe</item>
      </entry>
      <entry key="script">mvn versions:set "-DnewVersion=${tag}" -DartifactId=* -DgroupId=* -DoldVersion=*
git commit -am "${tag}"
mvn clean deploy --settings documentation/files/maven-settings.xml -Prelease</entry>
   </entry>
</p>

Here is my log output at the end of the release:

+ mv /home/r/repo . 
++ whoami 
+ chown -R root repo 
+ '[' -n '' ']' 
++ whoami 
+ sudo chown -R rultor repo 
+ cd repo 
+ git checkout __rultor Already on '__rultor' 
+ git tag 1.00.019 -m '1.00.019: tagged by rultor.com' 
+ git reset --hard HEAD is now at 2b17609 1.00.019 
+ git clean -fd 
+ git checkout master Switched to branch 'master' 
+ git branch -D __rultor Deleted branch __rultor (was 2b17609). 
+ git push --all origin Everything up-to-date 
+ git push --tags origin To [email protected]:jeromebridge/inspro-integration.git * [new tag]  1.00.019 -> 1.00.019

@alex-palevsky
Copy link
Contributor

@yegor256 last puzzled solved 662-8cc0c29a/#832

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2022

@yegor256 the puzzle #1371 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants