Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deta_drive): implement method in DetaDrive #13

Open
wants to merge 1 commit into
base: deta-drive
Choose a base branch
from

Conversation

DonnC
Copy link

@DonnC DonnC commented Apr 14, 2022

added methods implementation

WP

added delete implementation
added list files implementation
added download file impl
minor changes
@yeikel16 yeikel16 changed the base branch from main to deta-drive April 14, 2022 17:21
@yeikel16 yeikel16 changed the title Feat/drive/dev feat(deta_drive): implement method in DetaDrive Apr 14, 2022
@yeikel16
Copy link
Owner

Hello, thanks for starting to work on this feature, I see that you are missing some things to complete.

  • Start from the deta-drive branch that I created to work on this feature, I see you started from the main branch, so it's easier to work on the same thing.
  • Make sure that the implementation that exists in DioClientDetaApi works correctly when using these methods in DetaDrive. I'll make sure it works correctly on the HttpClientDetaApi side.
  • You must create tests to ensure that the written code works well and is proof of changes. You can guide yourself from the implementation I made in the uploadFile method.

If you get stuck somewhere, you can tell me and we'll solve it between the two of us, it's about learning. I left you some comments in your code to improve the implementation, so that everything is in the best possible way.

@DonnC
Copy link
Author

DonnC commented Apr 14, 2022

Okay thanks for that, thought had worked from the deta-drive branch but will double check from now on

Still trying to get a hang of some things but will definitely reach out when i get stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants