Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code in PackagesListBuilder + Refactor tests #157

Merged
merged 35 commits into from
Dec 9, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 8, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@vjik vjik added status:under development Someone is working on a pull request. type:test Test labels Dec 8, 2023
@vjik vjik self-assigned this Dec 8, 2023
Copy link

what-the-diff bot commented Dec 8, 2023

PR Summary

  • Deletion of Unwanted Files
    A file named 'merge-plan.php' was removed from our codebase. It's a cleanup effort that helps in maintaining code quality

  • Modification of Test Configurations
    The 'ConfigTest.php' file was also updated, further hinting towards improvements in our code testing environment and configurations. This might lead to more reliable code testing.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8288d9) 99.59% compared to head (b786e56) 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #157      +/-   ##
=============================================
+ Coverage     99.59%   100.00%   +0.40%     
+ Complexity      282       277       -5     
=============================================
  Files            22        22              
  Lines           736       728       -8     
=============================================
- Hits            733       728       -5     
+ Misses            3         0       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik changed the title Refactor tests Remove unnecessary code in PackagesListBuilder + Refactor tests Dec 8, 2023
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. type:test Test labels Dec 8, 2023
@vjik vjik requested a review from a team December 8, 2023 14:08
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Dec 8, 2023
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Dec 9, 2023
@vjik vjik merged commit 5c19a99 into master Dec 9, 2023
23 of 25 checks passed
@vjik vjik deleted the refactor-tests branch December 9, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants