Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ColumnFactory #368

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Refactor ColumnFactory #368

merged 3 commits into from
Nov 8, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 2, 2024

Related PR

Q A
Is bugfix?
New feature?
Breaks BC? ✔️/❌
Fixed issues

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.73%. Comparing base (4f85a22) to head (c36b2b4).

Files with missing lines Patch % Lines
src/Column/ColumnFactory.php 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
- Coverage     99.73%   99.73%   -0.01%     
+ Complexity      256      254       -2     
============================================
  Files            27       27              
  Lines           768      762       -6     
============================================
- Hits            766      760       -6     
  Misses            2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 1364341 into master Nov 8, 2024
2 checks passed
@Tigrov Tigrov deleted the refactory-column-factory branch November 8, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants