Range parsers with tests b #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerych1984
commented
Nov 2, 2021
Gerych1984
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
darkdef
approved these changes
Nov 13, 2021
terabytesoftw
approved these changes
Nov 14, 2021
| return [$min, $max]; | ||
| } | ||
|
|
||
| private static function parseNumRange(?string $lower, ?string $upper, bool $includeLower, bool $includeUpper): array |
There was a problem hiding this comment.
bool $includeLower, bool $includeUpper they are not used within the method.
There was a problem hiding this comment.
I will fix that and add new short immutable methods like withType, asInt, asNum etc at nearest time
| return [$min, $max]; | ||
| } | ||
|
|
||
| private static function parseTsRange(?string $lower, ?string $upper, bool $includeLower, bool $includeUpper): array |
There was a problem hiding this comment.
bool $includeLower, bool $includeUpper they are not used within the method.
| return [$min, $max]; | ||
| } | ||
|
|
||
| private static function parseTsTzRange(?string $lower, ?string $upper, bool $includeLower, bool $includeUpper): array |
There was a problem hiding this comment.
bool $includeLower, bool $includeUpper they are not used within the method.
|
@Gerych1984 do you have time to rebase this PR and adjust it based on comments? |
Yes. I haven't forgotten about this and this PR. I'll try to find time to get them in the right shape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.