Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Query without ->from() #760

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 27, 2023

Related PR

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Sep 27, 2023

PR Summary

  • Inclusion of Expression Class
    The code now includes the Expression class from Yiisoft\Db\Expression\Expression in the CommonQueryTest.php file. This allows us to work with expressions in the database context effectively.

  • New Test Case: testSelectWithoutFrom
    A new test case named testSelectWithoutFrom has been added into the CommonQueryTest.php file. This specifically examines how the select function of the Query class behaves when used without a from clause. This step helps validate the reliability and robustness of our database querying process.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29ae078) 99.64% compared to head (d6f4c5c) 99.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #760   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
  Complexity     1271     1271           
=========================================
  Files            63       63           
  Lines          3080     3080           
=========================================
  Hits           3069     3069           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov changed the title Execute $query->select() without ->from() Execute Query without ->from() Sep 27, 2023
@Tigrov Tigrov marked this pull request as ready for review January 10, 2024 13:13
@Tigrov Tigrov merged commit 38c9090 into yiisoft:master Jan 14, 2024
85 of 86 checks passed
@Tigrov Tigrov deleted the select-without-from branch January 14, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants