Wrap createCommand for respecting \yii\db\ActiveRecord::getDb

yiisoft · Jan 16, 2025 · 442761d · 442761d
1 parent dcf8674
commit 442761d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/framework/data/ActiveDataProvider.php b/framework/data/ActiveDataProvider.php
@@ -119,8 +119,14 @@ public function all($db = null)
             {
                 return $this->wrappedQuery->populate(parent::all($db));
             }
+            public function createCommand($db = null)
+            {
+                $command = $this->wrappedQuery->createCommand($db);
+                $this->from(['q' => "({$command->getSql()})"])->params($command->params);
+                return parent::createCommand($command->db);
+            }
         };
-        $wrapper->select('*')->from(['q' => $this->query]);
+        $wrapper->select('*');
         $wrapper->wrappedQuery = $this->query;
         $wrapper->emulateExecution = $this->query->emulateExecution;
 

diff --git a/tests/framework/data/ActiveDataProviderTest.php b/tests/framework/data/ActiveDataProviderTest.php
@@ -204,7 +204,6 @@ public function testPaginationWithUnionQuery()
         $q1 = Item::find()->where(['category_id' => 2])->with('category');
         $q2 = Item::find()->where(['id' => [2, 4]]);
         $provider = new ActiveDataProvider([
-            'db' => $this->getConnection(),
             'query' => $q1->union($q2)->indexBy('id'),
         ]);
         $pagination = $provider->getPagination();