Fix namespaces in fixtures #15770
Closed
Fix namespaces in fixtures #15770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2018
samdark
reviewed
May 14, 2019
| @@ -53,7 +53,7 @@ class FixtureController extends Controller | |||
| /** | |||
| * @var string default namespace to search fixtures in | |||
| */ | |||
| public $namespace = 'tests\unit\fixtures'; | |||
| public $namespace = 'tests\fixtures'; | |||
There was a problem hiding this comment.
Looks like potential backwards compatibility break.
samdark
added
status:under discussion
and removed
status:code review
arzzen
approved these changes
Sep 18, 2019
|
@arzzen have you tested it locally? |
|
Completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15769.