Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility PHP 8.3. #20073

Closed
wants to merge 1 commit into from
Closed

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Nov 23, 2023

PR Summary

  • Integration of PHP Version 8.3
    The latest PHP version 8.3 has been added to our GitHub workflow in multiple files (build.yml, ci-mssql.yml, ci-mysql.yml, ci-pgsql.yml, ci-sqlite.yml). These additions ensure our codebases can run and are compatible with this PHP version which will aid in increased performance and efficiency.

  • Modification in BaseDataProviderTest
    In the file BaseDataProviderTest.php, there was a change in the value set for counter property. This adjustment will help in enhancing the test coverage making the code more reliable and bug-free.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fdb805) 48.02% compared to head (b6527e8) 48.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20073   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files         445      445           
  Lines       43889    43889           
=======================================
  Hits        21077    21077           
  Misses      22812    22812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw
Copy link
Member Author

#19957 (reply in thread)

@terabytesoftw terabytesoftw deleted the php-83 branch November 23, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant