Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility PHP 8.3. #20074

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add compatibility PHP 8.3. #20074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
extensions: apcu, curl, dom, imagick, intl, mbstring, mcrypt, memcached
coverage: none
os: ubuntu-latest
- php: 8.3
extensions: apcu, curl, dom, imagick, intl, mbstring, mcrypt, memcached
coverage: none
os: ubuntu-latest

steps:
- name: Generate french locale.
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-mssql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
mssql: server:2019-latest
- php: 8.2
mssql: server:2022-latest
- php: 8.3
mssql: server:2022-latest

services:
mssql:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
- 8.0
- 8.1
- 8.2
- 8.3

mysql:
- 5.7
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-pgsql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
- 7.4
- 8.0
- 8.1
- 8.2
- 8.3

pgsql:
- 10
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-sqlite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
- 8.0
- 8.1
- 8.2
- 8.3

steps:
- name: Checkout.
Expand Down
108 changes: 54 additions & 54 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/framework/data/BaseDataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function testGenerateId()
$rc = new \ReflectionClass(BaseDataProvider::className());
$rp = $rc->getProperty('counter');
$rp->setAccessible(true);
$rp->setValue(null);
$rp->setValue(new ConcreteDataProvider(), null);

$this->assertNull((new ConcreteDataProvider())->id);
$this->assertNotNull((new ConcreteDataProvider())->id);
Expand Down
Loading