Fixed raster reading and coordinate system #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauro3
commented
Dec 22, 2023
application/dataset.jl
Outdated
| vmag_epsg = dataset.v2016_2017 | ||
| # ice_thic, ice_surf, bed_surf = GlacioTools.geom_select("Rhone", "B43-03", "application/datasets/Rhone"; do_save=false) | ||
| ice_thic, ice_surf, bed_surf = GlacioTools.geom_select("Aletsch", "B36-26", "datasets/Aletsch"; do_save=false) | ||
| ice_thic = reverse(ice_thic[:,:,1], dims=2) # reads it into memory |
There was a problem hiding this comment.
@luraess : maybe this is something which should be done in geom_select?
There was a problem hiding this comment.
It's a bit annoying with those reversed dims, but I find it easier when they are as expected. And all the same. Otherwise you can run into troubles when you just work with the underlying matrix. See eg https://github.com/eth-vaw-glaciology/GlacioTools.jl/blob/4244ee744413efa4cb6be2ae6f32dd90580c00b8/src/Antarctica.jl#L96
|
Actually, maybe the reversing will not be needed soon with the next major version of Rasters, see: rafaqz/Rasters.jl#545 (but you should still merge this, but then update as needed) |
|
Closing as addressed in #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you have other raster datasets to be read in? If so, let me know asap and I can take a look.
Note, the makie plotting I did not test as I just used Plots (commented code block)