Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: Fixes component parsing errors #20

Merged
merged 1 commit into from
Apr 16, 2018
Merged

[test]: Fixes component parsing errors #20

merged 1 commit into from
Apr 16, 2018

Conversation

harshit98
Copy link

@harshit98 harshit98 commented Apr 15, 2018

Closes #18

Fixes the component parsing errors which were reported by Travis earlier. Merge this PR if testing works fine. ✨

Fixes Travis report for building project

Reverts back the directory of missing file

Fixes lint error
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (visualize@4be7473). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             visualize      #20   +/-   ##
============================================
  Coverage             ?   89.74%           
============================================
  Files                ?        6           
  Lines                ?       39           
  Branches             ?        1           
============================================
  Hits                 ?       35           
  Misses               ?        4           
  Partials             ?        0
Impacted Files Coverage Δ
...t-visualize/src/app/terminal/terminal.component.ts 78.57% <ø> (ø)
git-visualize/src/app/app.component.ts 100% <ø> (ø)

@ParthS007 ParthS007 requested a review from gabru-md April 15, 2018 18:41
@gabru-md
Copy link
Member

Thank You so mush @harshit98 for solving travis errors.
:)

@gabru-md gabru-md merged commit 4ecf19d into yogdaan:visualize Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants