Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/multiple targets in org bulk upload via csv #1109

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Feat/multiple targets in org bulk upload via csv #1109

merged 4 commits into from
Dec 18, 2023

Conversation

SeanOverton
Copy link
Contributor

@SeanOverton SeanOverton commented Dec 6, 2023 •
edited
Loading

Testing:

  • locally with various csv's leaving parameters out (description, organisation) are both optional parameters ✅
  • the organisation can be already existing otherwise will be created on upload of the csv ✅

@SeanOverton SeanOverton mentioned this pull request Dec 6, 2023
Closed
@AnonymousWP AnonymousWP linked an issue Dec 6, 2023 that may be closed by this pull request
Add targets from the organisation #604
Open
AnonymousWP
AnonymousWP suggested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're using US English in reNgine, we'd like to keep this consistent. Also, thank you for this PR!

web/targetApp/templates/target/add.html Outdated Show resolved Hide resolved
web/targetApp/templates/target/add.html Outdated Show resolved Hide resolved
@SeanOverton
Copy link
Contributor Author

As we're using US English in reNgine, we'd like to keep this consistent. Also, thank you for this PR!

Yeh! This spelling caught me out a few times 😆 thanks for catching this

@yogeshojha yogeshojha changed the base branch from master to release/2.1.0 December 18, 2023 01:30
@yogeshojha yogeshojha merged commit a88cae7 into yogeshojha:release/2.1.0 Dec 18, 2023
@yogeshojha yogeshojha added this to the release 2.1.0 milestone Dec 18, 2023
@pythonSB
Copy link

Has this feature been removed from the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyray psyray psyray approved these changes

@yogeshojha yogeshojha yogeshojha approved these changes

@AnonymousWP AnonymousWP AnonymousWP approved these changes

Assignees
No one assigned
Labels
release/2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add targets from the organisation
5 participants
@SeanOverton @pythonSB @psyray @yogeshojha @AnonymousWP