Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/issue 492 add orgs when adding targets #1110

Conversation

SeanOverton
Copy link
Contributor

@SeanOverton SeanOverton commented Dec 6, 2023

Fixes #492.

This PR introduces optional input for adding target to an organization when adding target via:

  1. Normal add target form
  2. The quick add target modal (and thus the quick add target API)
  3. With organizations via normal form and via modal for quick add

@AnonymousWP
Copy link
Contributor

AnonymousWP commented Dec 6, 2023

Thanks for your PR. 😄

Testing:
added targets with organizations via normal form and via modal for quick add ✅

Does this mean you're still about to push new commits, i.e. this PR is WIP? In that case, convert this PR to a draft.

Oh, by the way, for future PRs: please use closing keywords instead of "addresses " as that will automatically link the correct issue to this PR.

@SeanOverton
Copy link
Contributor Author

Testing complete ✅
ie. i think this is PR is ready for review

Thanks for pointing out the closing keywords (these are some of my first open source contributions so.... still learning the ropes) Will use these from now. Cheers!

@yogeshojha
Copy link
Owner

Woah, excellent !

@AnonymousWP
Copy link
Contributor

Wait to merge. Pending for 2.1.0.

@yogeshojha yogeshojha added this to the release 2.1.0 milestone Dec 18, 2023
@yogeshojha yogeshojha changed the base branch from master to release/2.1.0 December 18, 2023 01:31
@yogeshojha yogeshojha merged commit 045b6f5 into yogeshojha:release/2.1.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create organization when adding targets
4 participants