Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really fix playwright fr finally #1733

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Really fix playwright fr finally #1733

merged 1 commit into from
Jan 1, 2025

Conversation

djahandarie
Copy link
Collaborator

@djahandarie djahandarie commented Jan 1, 2025 •
edited
Loading

Another fix on top of #1728 / #1727 / #1720

Tested as best as I could on my fork, but will still not know for sure if this works until the new screenshots get regenerated.

@djahandarie djahandarie requested a review from a team as a code owner January 1, 2025 03:54
@djahandarie djahandarie added kind/meta The issue or PR is meta area/ci The issue or PR is related to continuous integration and/or continuous delivery labels Jan 1, 2025
@djahandarie djahandarie added this pull request to the merge queue Jan 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

⚠️ Visual changes detected by playwright; please check the report to verify if they are desirable.

Merged via the queue into yomidevs:master with commit e1133cc Jan 1, 2025
25 checks passed
@djahandarie djahandarie deleted the really-fix-playwright-fr-finally branch January 1, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djahandarie @jamesmaa