#1698 when show action bar setting is on, shows current profiles language #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would make more sense to show the name of the profile there instead. |
StefanVukovic99
added
kind/enhancement
|
oops, when you have aciton bar location to left or right it doesn't show properly, need to fix that |
Mjishu
force-pushed
the
show-language-action-bar
branch
from
fb5b9c5 to
3352182
Compare
Mjishu
force-pushed
the
show-language-action-bar
branch
from
3352182 to
03fefc5
Compare
|
Can you upload screenshots to the main PR comment when making visual changes? Also agreed in showing profile name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves issue #1698
Creates a new P element in popup.html -> selects that element in popup-menu.js -> updates text content on start and when profile changes.
added additional styling (without it the text gets cut off)