Permit scheme build stage to be optional #1303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsthejb
commented
Dec 24, 2022
| @@ -8,7 +8,7 @@ public typealias BuildType = XCScheme.BuildAction.Entry.BuildFor | |||
| public struct Scheme: Equatable { | |||
|
|
|||
| public var name: String | |||
| public var build: Build | |||
| public var build: Build! | |||
There was a problem hiding this comment.
This should of course should be Build?, but changing to a full optional led to many type-inference errors in SpecLoadingTests that I wasn't able to easily fix
itsthejb
commented
Dec 24, 2022
Comment on lines
+10
to
+12
| test: | ||
| targets: | ||
| - Target |
There was a problem hiding this comment.
Use case: scheme has only a test action, no build
itsthejb
force-pushed
the
permit-optional-scheme-build
branch
from
70485ef to
d04986e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the excellent work on this project!
Here's a small tweak, I noticed: currently it's not possible to define schemes with an optional
Buildstage:In fact, it's entirely legal to define a scheme without build. We're currently looking into this as the only way to allow running of tests in child modules, when those child modules are Swift Packages: it's not possible to create schemes to build the modules, but it is possible to create scheme to test, and the modules will be implicitly built.
Regardless of this, the spec should permit everything that's permitted by Xcode, so I made this initial rough PR.
Thanks very much