Skip to content

Commit

Permalink
refactor: Specify dependencies for Riverpod annotations
Browse files Browse the repository at this point in the history
  • Loading branch information
yorifuji committed Apr 6, 2024
1 parent 74acb46 commit 9ad796c
Show file tree
Hide file tree
Showing 13 changed files with 10 additions and 15 deletions.
2 changes: 1 addition & 1 deletion lib/provider/package_info_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'package_info_provider.g.dart';

@riverpod
@Riverpod(dependencies: [])
PackageInfo packageInfo(PackageInfoRef ref) => throw UnimplementedError();
4 changes: 2 additions & 2 deletions lib/repository/favorite_repository.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'favorite_repository.g.dart';

@riverpod
@Riverpod(dependencies: [])
FavoriteRepository favoriteRepository(FavoriteRepositoryRef ref) =>
FavoriteRepository(ref.watch(databaseProvider));

Expand Down Expand Up @@ -51,7 +51,7 @@ class FavoriteRepository {
}
}

@riverpod
@Riverpod(dependencies: [])
Stream<List<Favorite>> favoriteStream(FavoriteStreamRef ref) {
final database = ref.watch(databaseProvider);
final query = database.select(database.favoriteDB)
Expand Down
4 changes: 2 additions & 2 deletions lib/repository/recipe_note_repository.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'recipe_note_repository.g.dart';

@riverpod
@Riverpod(dependencies: [])
RecipeNoteRepository recipeNoteRepository(RecipeNoteRepositoryRef ref) =>
RecipeNoteRepository(ref.watch(databaseProvider));

Expand Down Expand Up @@ -43,7 +43,7 @@ class RecipeNoteRepository {
}
}

@riverpod
@Riverpod(dependencies: [])
Stream<List<RecipeNote>> recipeNoteStream(RecipeNoteStreamRef ref) {
final database = ref.watch(databaseProvider);
final query = database.select(database.recipeNoteDB)
Expand Down
2 changes: 1 addition & 1 deletion lib/service/favorite_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'favorite_service.g.dart';

@riverpod
@Riverpod(dependencies: [FavoriteRepository])
FavoriteService favoriteService(FavoriteServiceRef ref) =>
FavoriteService(ref.watch(favoriteRepositoryProvider));

Expand Down
2 changes: 1 addition & 1 deletion lib/service/recipe_note_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'recipe_note_service.g.dart';

@riverpod
@Riverpod(dependencies: [RecipeNoteRepository])
RecipeNoteService recipeNoteService(RecipeNoteServiceRef ref) =>
RecipeNoteService(ref.watch(recipeNoteRepositoryProvider));

Expand Down
2 changes: 1 addition & 1 deletion lib/ui/recipe_note/edit/recipe_note_edit_view_model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class RecipeNoteEditState with _$RecipeNoteEditState {
bool get isValid => title.isNotEmpty && description.isNotEmpty;
}

@riverpod
@Riverpod(dependencies: [RecipeNoteService])
class RecipeNoteEditViewModel extends _$RecipeNoteEditViewModel {
late RecipeNoteService _recipeNoteService;
@override
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/search/search_view_model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SearchState with _$SearchState {
}) = _SearchState;
}

@riverpod
@Riverpod(dependencies: [])
class SearchViewModel extends _$SearchViewModel {
late RecipeService _recipeService;
@override
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/settings/settings_view_model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class SettingsState with _$SettingsState {
}) = _SettingsState;
}

@riverpod
@Riverpod(dependencies: [])
class SettingsViewModel extends _$SettingsViewModel {
@override
SettingsState build() {
Expand Down
1 change: 0 additions & 1 deletion test/golden_test/favorite_page_golden_test.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// ignore_for_file: scoped_providers_should_specify_dependencies
import 'package:buzz_recipe_viewer/i18n/strings.g.dart';
import 'package:buzz_recipe_viewer/repository/favorite_repository.dart';
import 'package:buzz_recipe_viewer/repository/favorite_repository_mock.dart';
Expand Down
1 change: 0 additions & 1 deletion test/golden_test/recipe_note_edit_page_golden_test.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// ignore_for_file: scoped_providers_should_specify_dependencies
import 'package:buzz_recipe_viewer/i18n/strings.g.dart';
import 'package:buzz_recipe_viewer/ui/recipe_note/edit/recipe_note_edit_page.dart';
import 'package:buzz_recipe_viewer/ui/recipe_note/edit/recipe_note_edit_view_model.dart';
Expand Down
1 change: 0 additions & 1 deletion test/golden_test/recipe_note_page_golden_test.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// ignore_for_file: scoped_providers_should_specify_dependencies
import 'package:buzz_recipe_viewer/i18n/strings.g.dart';
import 'package:buzz_recipe_viewer/repository/recipe_note_repository.dart';
import 'package:buzz_recipe_viewer/repository/recipe_note_repository_mock.dart';
Expand Down
1 change: 0 additions & 1 deletion test/golden_test/search_page_golden_test.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// ignore_for_file: scoped_providers_should_specify_dependencies
import 'package:buzz_recipe_viewer/i18n/strings.g.dart';
import 'package:buzz_recipe_viewer/ui/search/search_page.dart';
import 'package:buzz_recipe_viewer/ui/search/search_view_model.dart';
Expand Down
1 change: 0 additions & 1 deletion test/golden_test/settings_page_golden_test.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// ignore_for_file: scoped_providers_should_specify_dependencies
import 'package:buzz_recipe_viewer/i18n/strings.g.dart';
import 'package:buzz_recipe_viewer/provider/package_info_provider.dart';
import 'package:buzz_recipe_viewer/ui/settings/settings_page.dart';
Expand Down

0 comments on commit 9ad796c

Please sign in to comment.