Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(update vrt workflow): Refine cache strategy and steps #315

Closed
wants to merge 0 commits into from
Closed

ci(update vrt workflow): Refine cache strategy and steps #315

wants to merge 0 commits into from

Conversation

yorifuji
Copy link
Owner

@yorifuji yorifuji commented Dec 12, 2023 •
edited by ghost
Loading

Summary by CodeRabbit

- 新機能: 実際の画像と期待される画像を作成するための`crate-actual-images`および`crate-expected-images`ジョブを追加しました。
- 改善: キャッシュ管理の効率化と正確性向上のために、キャッシュ参照方法を更新しました。
- 新機能: 画像比較の自動化を実現する`compare`ジョブを新たに追加しました。
- 改善: キャッシュの保存と復元ステップを追加してパフォーマンスを向上させました。

@ghost
Copy link

ghost commented Dec 12, 2023 •
edited by ghost
Loading

CodeRabbit

Walkthrough
この変更では、GitHub Actionsのワークフローが改善されており、画像キャッシュの管理とビジュアルリグレッションテスト(VRT)のプロセスが最適化されています。具体的には、キャッシュ参照方法の更新、新しいジョブの追加、および画像比較のためのcompareジョブの導入が含まれます。

Changes

ファイル 変更内容
.github/workflows/vrt.yml キャッシュ参照方法の更新、actual-cacheとexpected-cacheの分割、crate-expected-imagesとcrate-actual-imagesジョブの追加、compareジョブの導入

🐰🌟

画像のキャッシュを整理し、
新しい流れを作り上げた
比較して差異を見つけるために
コードのうさぎが跳ねる

期待される美しさを
実際の姿と重ね合わせ
進歩の道を照らす光
GitHubの星空に輝く

🌌✨

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and 9276ebb commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@yorifuji yorifuji force-pushed the feature/vrt branch 2 times, most recently from 2546c31 to c215ce5 Compare December 12, 2023 11:07
ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and c215ce5 commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@yorifuji yorifuji force-pushed the feature/vrt branch 2 times, most recently from 92f2143 to b6f8d39 Compare December 12, 2023 11:14
ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and b6f8d39 commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Review comments generated (5)
  • Review: 4
  • LGTM: 1
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and 92932f2 commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Files ignored due to filter (1)
  • regconfig.json
Review comments generated (6)
  • Review: 4
  • LGTM: 2
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
@github-actions github-actions bot deleted a comment Dec 12, 2023
ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and c85f2d8 commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Files ignored due to filter (1)
  • regconfig.json
Files not summarized due to errors (1)
  • .github/workflows/vrt.yml (nothing obtained from openai)
Files not reviewed due to errors (1)
  • .github/workflows/vrt.yml (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@yorifuji yorifuji force-pushed the feature/vrt branch 2 times, most recently from c5650d0 to 6797706 Compare December 12, 2023 11:37
ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and a2d897b commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Files ignored due to filter (1)
  • regconfig.json
Files not summarized due to errors (1)
  • .github/workflows/vrt.yml (nothing obtained from openai)
Files not reviewed due to errors (1)
  • .github/workflows/vrt.yml (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between c580cec and 0309eb1 commits.
Files selected (1)
  • .github/workflows/vrt.yml (5)
Files ignored due to filter (1)
  • regconfig.json
Files not summarized due to errors (1)
  • .github/workflows/vrt.yml (nothing obtained from openai)
Files not reviewed due to errors (1)
  • .github/workflows/vrt.yml (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

ghost
ghost reviewed Dec 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit

Commits Files that changed from the base of the PR and between 0309eb1 and a20b44c commits.
Files selected (1)
  • lib/i18n/strings.g.dart (40)
Files ignored due to filter (1)
  • lib/i18n/strings.i18n.json
Files not summarized due to errors (1)
  • lib/i18n/strings.g.dart (diff tokens exceeds limit)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@github-actions GitHub Actions
Copy link
Contributor

❗ reg-suit has checked for visual changes

🔴 Changed🟡 New🟤 Deleted🔵 Passing
1003

📊 Download Report

You can download the report from the artifact here

📝 Log

[reg-suit] info version: 0.12.2
[reg-suit] info Skipped to detect the previous snapshot key because key generator plugin is not set up.
[reg-suit] info Comparison Complete
[reg-suit] info    Changed items: 1
[reg-suit] info    New items: 0
[reg-suit] info    Deleted items: 0
[reg-suit] info    Passed items: 3

@yorifuji yorifuji closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@yorifuji yorifuji

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yorifuji