[YDS-#259] TextField에 onErrorChange 기본값 추가 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
어디서 보셨는지 모르겠지만 버전 업데이트 해주셔야 해요! |
|
앗 제가 착각했었네요! Rein님이 2.5.7로 업데이트 해주셔서 2.5.8로 미리 해뒀습니다..! |
|
앞에거 머지되고 충돌 해결되면 approve 드리겠습니다~! |
|
@cometj03 @leeeyubin 제 pr 머지했습니답! |
|
@cometj03 컨플릭 해결했습니다! 어프루브 부탁드려요! |
cometj03
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SimpleTextField를 사용할 때 onErrorChange의 기본값이 필요해 추가했습니다.
Describe your changes
Issue
To reviewers
version.properties의 버전을 업데이트 하지 않아도 된다고 하셔서 그대로 뒀습니다!
=> 업데이트 완료했습니다!
PR 올리기 전 체크 리스트