Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround heaptrack #4719

Draft
wants to merge 2 commits into
base: 25.lts.1+
Choose a base branch
from
Draft

Workaround heaptrack #4719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ddbf96
Workaround heaptrack
kaidokert Jan 17, 2025
4ff43ec
Display the custom signal name too
kaidokert Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions starboard/shared/signal/signal_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ inline const char* GetSignalName(int signal_id) {
return "SIGUSR1";
case SIGUSR2:
return "SIGUSR2";
case SIGRTMIN:
return "SIGRTMIN";
default:
return "UNKNOWN";
}
Expand Down
6 changes: 3 additions & 3 deletions starboard/shared/signal/suspend_signals.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace signal {
namespace {

const std::initializer_list<int> kAllSignals = {SIGUSR1, SIGUSR2, SIGCONT,
SIGTSTP, SIGPWR};
SIGRTMIN, SIGTSTP, SIGPWR};

int SignalMask(std::initializer_list<int> signal_ids, int action) {
sigset_t mask;
Expand Down Expand Up @@ -145,7 +145,7 @@ void InstallSuspendSignalHandlers() {
// http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_04.html
SignalMask(kAllSignals, SIG_BLOCK);

SetSignalHandler(SIGUSR1, &Conceal);
SetSignalHandler(SIGRTMIN, &Conceal);
SetSignalHandler(SIGUSR2, &LowMemory);
SetSignalHandler(SIGCONT, &Focus);
SetSignalHandler(SIGTSTP, &Freeze);
Expand All @@ -157,7 +157,7 @@ void UninstallSuspendSignalHandlers() {
#if !defined(MSG_NOSIGNAL)
SetSignalHandler(SIGPIPE, SIG_DFL);
#endif
SetSignalHandler(SIGUSR1, SIG_DFL);
SetSignalHandler(SIGRTMIN, SIG_DFL);
SetSignalHandler(SIGUSR2, SIG_DFL);
SetSignalHandler(SIGCONT, SIG_DFL);
SetSignalHandler(SIGPWR, SIG_DFL);
Expand Down
Loading