Merge pull request #27 from ysk24ok/fix_domain_in_default_template

Fix bug that the domain link is broken
ysk24ok · May 18, 2021 · 89f31bb · 89f31bb
2 parents 94597ec + 976bfe7
commit 89f31bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/jekyll-linkpreview.rb b/lib/jekyll-linkpreview.rb
@@ -254,7 +254,7 @@ def gen_default_template(hash)
       </div>
     </div>
     <div class="jekyll-linkpreview-footer">
-      <a href="#{domain}" target="_blank">#{domain}</a>
+      <a href="//#{domain}" target="_blank">#{domain}</a>
     </div>
   </div>
 </div>

diff --git a/spec/jekyll-linkpreview_spec.rb b/spec/jekyll-linkpreview_spec.rb
@@ -544,6 +544,7 @@ def check_default_template_with_image_is_rendered(html)
       expect(doc.xpath('//h2[@class="jekyll-linkpreview-title"]/a').inner_text).to eq @title
       expect(doc.xpath('//h2[@class="jekyll-linkpreview-title"]/a').attribute('href').value).to eq @url
       expect(doc.xpath('//div[@class="jekyll-linkpreview-footer"]/a').inner_text).to eq @domain
+      expect(doc.xpath('//div[@class="jekyll-linkpreview-footer"]/a').attribute('href').value).to eq "//#{@domain}"
       expect(doc.xpath('//div[@class="jekyll-linkpreview-image"]/a/img').attribute('src').value).to eq @image
       expect(doc.xpath('//div[@class="jekyll-linkpreview-description"]').inner_text).to eq @description
     end
@@ -553,6 +554,7 @@ def check_default_template_without_image_is_rendered(html)
       expect(doc.xpath('//h2[@class="jekyll-linkpreview-title"]/a').inner_text).to eq @title
       expect(doc.xpath('//h2[@class="jekyll-linkpreview-title"]/a').attribute('href').value).to eq @url
       expect(doc.xpath('//div[@class="jekyll-linkpreview-footer"]/a').inner_text).to eq @domain
+      expect(doc.xpath('//div[@class="jekyll-linkpreview-footer"]/a').attribute('href').value).to eq "//#{@domain}"
       expect(doc.xpath('//div[@class="jekyll-linkpreview-image"]')).to be_empty
       expect(doc.xpath('//div[@class="jekyll-linkpreview-description"]').inner_text).to eq @description
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -254,7 +254,7 @@ def gen_default_template(hash) @@
           </div>
         </div>
         <div class="jekyll-linkpreview-footer">
-          <a href="#{domain}" target="_blank">#{domain}</a>
+          <a href="//#{domain}" target="_blank">#{domain}</a>
         </div>
       </div>
     </div>
@@ Expand Down @@