Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pp/FFmpegMetadata] Convert date strings to ISO 8601 #12253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

7x11x13
Copy link
Contributor

@7x11x13 7x11x13 commented Feb 1, 2025

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR converts the YYYYMMDD format used by extractors into YYYY-MM-DD format before embedding into the file with FFmpeg. It also uses release_date over upload_date as suggested: #12230 (comment)

Related:

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the bug Bug that is not site-specific label Feb 2, 2025
yt_dlp/postprocessor/ffmpeg.py Outdated Show resolved Hide resolved
yt_dlp/postprocessor/ffmpeg.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Feb 2, 2025
@7x11x13 7x11x13 requested a review from bashonly February 2, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific pending-fixes PR has had changes requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants