Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple views in a single window #137

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Multiple views in a single window #137

merged 6 commits into from
Dec 9, 2024

Conversation

matthewturk
Copy link
Member

This is my attempt at starting the windowing, or at least multi-view, system.

@matthewturk matthewturk marked this pull request as draft July 2, 2024 18:16
- src alpha
- dst alpha
blend_equation: func add
display_border:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new shader -- the rest are whitespace changes.

@matthewturk matthewturk changed the title WIP: Windowing system ish Multiple views in a single window Dec 5, 2024
@matthewturk matthewturk marked this pull request as ready for review December 5, 2024 18:20
@matthewturk
Copy link
Member Author

This works, to the extent that I'd like it to, and there's an example.

Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! couple of questions for you but LGTM

@chrishavlin chrishavlin added this to the 0.5.0 milestone Dec 6, 2024
@chrishavlin chrishavlin added the enhancement New feature or request label Dec 6, 2024
Copy link
Member Author

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the intent to tie this to mouse position at some point?

It is definitely something I want to support. But I don't know that I have it in me for this pull request.

Copy link
Member Author

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the intent to tie this to mouse position at some point?

It is definitely something I want to support. But I don't know that I have it in me for this pull request.

@chrishavlin
Copy link
Contributor

But I don't know that I have it in me for this pull request.

No worries haha :) it makes sense to get in the framework on its own in this PR, was just curious where you saw it headed next.

@chrishavlin chrishavlin merged commit c1d36ab into main Dec 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants