Skip to content

Commit

Permalink
[#4211] Retain delete markers on index tables only during backfill
Browse files Browse the repository at this point in the history
Summary:
Fix negation during ShouldRetainDeleteMarkers
Retain delete markers on index tables only during backfill

Issue introduced by 7c46f82

Test Plan: TBD. add unit test

Reviewers: bogdan, mikhail

Reviewed By: mikhail

Subscribers: kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8282
  • Loading branch information
amitanandaiyer committed Apr 14, 2020
1 parent 710486d commit 46a477d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/yb/tablet/tablet_retention_policy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void TabletRetentionPolicy::UnregisterReaderTimestamp(HybridTime timestamp) {
bool TabletRetentionPolicy::ShouldRetainDeleteMarkersInMajorCompaction() const {
// If the index table is in the process of being backfilled, then we
// want to retain delete markers until the backfill process is complete.
return !metadata_.schema().table_properties().IsBackfilling();
return metadata_.schema().table_properties().IsBackfilling();
}

HybridTime TabletRetentionPolicy::HistoryCutoffToPropagate(HybridTime last_write_ht) {
Expand Down

0 comments on commit 46a477d

Please sign in to comment.