Enable click's auto_envvar_prefix #20
Conversation
bean-grep's command line options to also be set via environment variables. This fixes zacchiro#8
This allows the beancount file to be specified via an environment variable BEANCOUNT_FILE, so you don't need to repeat it every time you run bean-grep. As part of this change, the PATTERN is now mandatory. This is because I don't really understand how to make click keep working the old way while also allowing the filename to come via an environment variable. We could pull the environment variable in ourselves manually but it feels cleaner to let click do that. I'm not sure if there's really a usecase for not having a pattern, anyway? That's just cat. I don't think regular grep allows no pattern?
|
Hm, I'm clearly not very good at github since I ended up including both changes in this single PR. Let me know if you want me to rework anything...... |
|
Thanks a lot for this, which would indeed be a good (easy) way to address defaults. More importantly though, I'd like to have at least a couple of tests for this, as it's something that can easily break unnoticed in the future. Can you give it a try? (I'm assuming click provides a way to set envvar via its CLI runner, but I never looked into it.) |
|
Give me a day or two to rework this (busy with family over the weekend so probably not until next week). |
Enable click's auto_envvar_prefix which allows bean-grep's command line options to also be set via environment variables.
The prefix is BEANGREP so the environment variables are BEANGREP_VERBOSE, BEANGREP_CASE_SENSITIVE, etc.
This fixes #8
n.b. I just realised I haven't updated the documentation for this but if the PR is accepted I can do that.
The environment variables could either be set permanently & globally via your shell config file or you could use something direnv to set them just while inside your beancount directory.
I think the current defaults actually work fine and don't see a need for this. However, this is scaffolding for my next pull request which will let you also specify the beancount file via an environment.