Allow options to be set via environment variables (to override defaults) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bean-grep's command line options to also be set via environment variables. This fixes zacchiro#8
variables to README.
|
Hello, thanks a lot, this looks great! I've very minimally reworked your commits in the envvar branch to merge related commits together and adapted the commit message style to be more consistent with previous commits. Can you please take a look and confirm you're OK with me merging that branch into main? |
|
Yep, looks good to me. |
|
Merged into main with 5a44873. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable click's auto_envvar_prefix to fix #8
I added a few tests and updated the README.
Let me know if you see anything else you want changed for this PR.
Cheers,
Justus