This repository has been archived by the owner on Jan 2, 2020. It is now read-only.
Eslint integration with airbnb extension #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ganeshpatro321 <[email protected]>
|
@ganeshpatro321 please make the components class-based as was in the original code. They provide easier readability and better management in cases involving a lot of events(which we have planned). |
|
Have disabled the react/prefer-stateless-function rule in eslint, there are some components which I have modified, lets change them to state components later again. Lets make sure that everyone has the same eslint configuration file. Imp: Remember to enable this rule later after some adequate amount of development, because unnecessary state components relates to the performance of the app |
|
Updated! @muskankhedia @Harkishen-Singh |
muskankhedia
suggested changes
Oct 20, 2019
muskankhedia
approved these changes
Oct 20, 2019
cjharkins
pushed a commit
to cjharkins/bench-routes-electron
that referenced
this pull request
Oct 20, 2019
* Eslint integration with airbnb extension Signed-off-by: ganeshpatro321 <[email protected]> * Reverted back to statefull components * Removed duplicates Signed-off-by: dib6596 <[email protected]>
cjharkins
pushed a commit
to cjharkins/bench-routes-electron
that referenced
this pull request
Oct 21, 2019
* Eslint integration with airbnb extension Signed-off-by: ganeshpatro321 <[email protected]> * Reverted back to statefull components * Removed duplicates Signed-off-by: dib6596 <[email protected]>
cjharkins
pushed a commit
to cjharkins/bench-routes-electron
that referenced
this pull request
Oct 21, 2019
* Eslint integration with airbnb extension Signed-off-by: ganeshpatro321 <[email protected]> * Reverted back to statefull components * Removed duplicates Signed-off-by: dib6596 <[email protected]>
ankitjena
pushed a commit
that referenced
this pull request
Oct 22, 2019
* Delete package-lock.json Signed-off-by: dib6596 <[email protected]> * fix: add install.md (#5) Signed-off-by: dib6596 <[email protected]> * sidebar ui added Signed-off-by: dib6596 <[email protected]> * router support Signed-off-by: dib6596 <[email protected]> * Add Settings Route and fix CSS Layout issues Signed-off-by: dib6596 <[email protected]> * Convert app to Typescript Signed-off-by: dib6596 <[email protected]> * dev header and notifs Signed-off-by: dib6596 <[email protected]> * notifications with animations Signed-off-by: dib6596 <[email protected]> * Update main.js Signed-off-by: dib6596 <[email protected]> * Do not ignore package-lock.json package-lock.json ensures everyone has same version of all modules and also makes npm install faster. See https://stackoverflow.com/a/44210813 Signed-off-by: dib6596 <[email protected]> * Update electron to 7.0 for better macOS Catalina compatibility Electron 7.0 reacts properly to macOS "Auto" theme change Signed-off-by: dib6596 <[email protected]> * Eslint integration with airbnb extension (#12) * Eslint integration with airbnb extension Signed-off-by: ganeshpatro321 <[email protected]> * Reverted back to statefull components * Removed duplicates Signed-off-by: dib6596 <[email protected]> * Update README.md Signed-off-by: dib6596 <[email protected]> * added rules for eslint, fixed files (#17) Signed-off-by: Harkishen-Singh <[email protected]> Signed-off-by: dib6596 <[email protected]> * Add Screenshot of Application Signed-off-by: dib6596 <[email protected]> * Add Settings Route and fix CSS Layout issues Signed-off-by: dib6596 <[email protected]> * Convert app to Typescript Signed-off-by: dib6596 <[email protected]> * dev header and notifs Signed-off-by: dib6596 <[email protected]> * Added travis and fixed eslint (#20) * Initial commit from Create React App * setting up * removed files * added header * updated start scripts * pull * pull * implemented travux * merge * added eslint for travis (#2) * Update README.md * added rules for eslint, fixed files (#17) Signed-off-by: Harkishen-Singh <[email protected]> * added eslint in travis * minor UI changes * fix * fix travis * fix travi Signed-off-by: dib6596 <[email protected]> * notifications with animations Signed-off-by: dib6596 <[email protected]> * Update main.js Signed-off-by: dib6596 <[email protected]> * Do not ignore package-lock.json package-lock.json ensures everyone has same version of all modules and also makes npm install faster. See https://stackoverflow.com/a/44210813 Signed-off-by: dib6596 <[email protected]> * Eslint integration with airbnb extension (#12) * Eslint integration with airbnb extension Signed-off-by: ganeshpatro321 <[email protected]> * Reverted back to statefull components * Removed duplicates Signed-off-by: dib6596 <[email protected]> * Update README.md Signed-off-by: dib6596 <[email protected]> * added rules for eslint, fixed files (#17) Signed-off-by: Harkishen-Singh <[email protected]> Signed-off-by: dib6596 <[email protected]> * Remove global access and fix style conflicts Signed-off-by: dib6596 <[email protected]> * Finish fixing merge conflicts Signed-off-by: dib6596 <[email protected]> * Remove local env directories Signed-off-by: dib6596 <[email protected]> * Remove redundant js/tsx files from migration Signed-off-by: dib6596 <[email protected]> * Fix eslint errors Signed-off-by: dib6596 <[email protected]> * Attempt to sign off past commits and fix merge conflicts Signed-off-by: dib6596 <[email protected]> * Stashing for merge into remote master * Add Settings in eslintrc to resolve extension conflicts Signed-off-by: dib6596 <[email protected]> * Update margin in homepage and remove screenshots Signed-off-by: ganeshpatro321 <[email protected]> * Add settings icon and fized layout of setting button Signed-off-by: ganeshpatro321 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Harkishen-Singh Please check
#10